[GR-64144] Support conditions in foreign configuration files. #11566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuration conditions to foreign configuration files. This is a prerequisite to be able to write platform-independent configuration files (as soon as we have platform conditions).
Parsing and consuming the conditions is straight forward since the foreign configuration parser just needs to inherit from
ConditionalConfigurationParser.However, I needed to change the process that creates the stubs since stub registration may now happen during the analysis (if a type becomes reachable).
Previously, we created all stubs before analysis and so it was guaranteed that the analysis saw all of them.
Now, we use
ImageHeapMaps to store the stubs which are automatically re-scanned.