Skip to content

[GR-64965] Do not try to validate type state propagation into disabled flows #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

[GR-64965] Do not try to validate type state propagation into disabled flows #11192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/TypeFlow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,10 +1112,13 @@ public boolean validateFixedPointState(BigBang bb) {
} else {
for (TypeFlow<?> use : getUses()) {
/*
* The type state of saturated flows is not updated anymore. FormalReceiverTypeFlow
* has a special update method.
* In the following cases, we cannot assume that the type state of the use is
* accurate: (1) disabled flows do not execute their on{Input|Observed}Saturated
* callbacks, so their state might not be up to date, (2) the type state of
* saturated flows is not updated anymore, (3) FormalReceiverTypeFlow has a special
* update method.
*/
if (use.isSaturated() || use instanceof FormalReceiverTypeFlow) {
if (!use.isFlowEnabled() || use.isSaturated() || use instanceof FormalReceiverTypeFlow) {
continue;
}
/*
Expand Down