[GR-60173] Register custom module-info compilation participant for JDK builds without JMODs #10161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
dougxc
reviewed
Nov 26, 2024
jerboaa
force-pushed
the
add_upgrade_module_jep493
branch
from
1f0ed93 to
ba73706
Compare
jerboaa
changed the title
jerboaa
force-pushed
the
add_upgrade_module_jep493
branch
from
a00e006 to
485f2eb
Compare
Collaborator
Author
|
@olpaw Could you help reviewing this please? Thank you! |
olpaw
reviewed
Nov 28, 2024
olpaw
reviewed
Nov 28, 2024
olpaw
changed the title
Member
I created an internal issue. Waiting for review comments to be addressed. |
olpaw
reviewed
Nov 28, 2024
olpaw
reviewed
Nov 28, 2024
Collaborator
Author
|
Thanks for the review. Working on an update. |
With JEP 493, part of JDK 24, it's possible to have JDK builds without the `jmods` folder. Currently substratevm builds assume `jmods` are always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled. All of this is activated only when `--no-jlinking` option is being used. This patch depends on (which adds the needed abstractions to mx): graalvm/mx#287
jerboaa
force-pushed
the
add_upgrade_module_jep493
branch
from
485f2eb to
b72ef98
Compare
Collaborator
Author
|
@olpaw Updated the PR. Thanks again! |
olpaw
approved these changes
Nov 28, 2024
Member
olpaw
left a comment
olpaw
left a comment
There was a problem hiding this comment.
Looking good. Integrating ... ⏳
Collaborator
Author
|
@olpaw Not sure if integration worked/works for this. Do I need to resolve the conflict or would that be counter-productive? |
Member
No worries. Already took care of that. |
graalvmbot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…K builds without JMODs #10161. PullRequest: graal/19464
Member
Collaborator
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With JEP 493, part of JDK 24, it's possible to have JDK builds without the
jmodsfolder. Currently substratevm builds assumejmodsare always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled.All of this is activated only when
--no-jlinkingoption is being used. It's a no-op for regular GraalVM builds.This patch depends on (which adds the needed abstractions to mx):
graalvm/mx#287
Edit:
mxversion7.35.1has the needed dependency. This is what 485f2eb updates to.Closes: graalvm#808