Skip to content

Fix distinct tests #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

Fix distinct tests #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff6cb1
Fix TestDistinctComputedColumn test.
BidyadharM Aug 25, 2025
3aef835
Fix TestDistinctWithAggregation test.
BidyadharM Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions tests/distinct_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,15 +138,14 @@ func TestDistinctWithVaryingCase(t *testing.T) {
}

func TestDistinctComputedColumn(t *testing.T) {
t.Skip()
type UserWithComputationColumn struct {
ID int64 `gorm:"primary_key"`
Name string
Col int64
}

if err := DB.Migrator().DropTable(&UserWithComputationColumn{}); err != nil {
t.Fatalf("failed to drop table: %v", err)
t.Logf("failed to drop table: %v", err)
}
if err := DB.AutoMigrate(&UserWithComputationColumn{}); err != nil {
t.Fatalf("failed to migrate table: %v", err)
Expand All @@ -163,8 +162,8 @@ func TestDistinctComputedColumn(t *testing.T) {

var computedRecords []int
if err := DB.
Table("USER_WITH_COMPUTATION_COLUMNS").
Select("DISTINCT col * 12 as Computed_Column").
Table("user_with_computation_columns").
Select("DISTINCT \"col\" * 12 as Computed_Column").
Order("Computed_Column").
Pluck("Computed_Column", &computedRecords).Error; err != nil {
t.Fatalf("failed to query distinct Computed Columns: %v", err)
Expand All @@ -174,7 +173,6 @@ func TestDistinctComputedColumn(t *testing.T) {
}

func TestDistinctWithAggregation(t *testing.T) {
t.Skip()
type UserWithComputationColumn struct {
ID int64 `gorm:"primaryKey"`
Name string
Expand All @@ -197,21 +195,21 @@ func TestDistinctWithAggregation(t *testing.T) {
}

if err := DB.Create(&records).Error; err != nil {
t.Fatalf("failed to insert test users: %v", err)
t.Logf("failed to insert test users: %v", err)
}

var result struct {
Sum int64
Sum float64
Avg float64
Count int64
Count int
}

err := DB.
Table("USER_WITH_COMPUTATION_COLUMNS").
Table("user_with_computation_columns").
Select(`
SUM(DISTINCT col) AS Sum,
AVG(DISTINCT col) AS Avg,
COUNT(DISTINCT col) AS Count
SUM(DISTINCT "col") AS "sum",
AVG(DISTINCT "col") AS "avg" ,
COUNT(DISTINCT "col") AS "count"
`).Scan(&result).Error

if err != nil {
Expand Down
Loading