Skip to content

fix: bucketing error at traffic allocation boundaries #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2020
Merged

fix: bucketing error at traffic allocation boundaries #365

merged 2 commits into from
Sep 22, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 22, 2020

This fixes a bug of bucketing at traffic allocation boundaries

  • EndOfRange should be compared with "less-than" but "less-than-equal" is used.
  • The bucket hashing generates 0 for userID+expID = “211314358930636871818513703488”.
  • When 0 <= 0, the bucketing interprets it as in-bucket by error, so returns a false result.

Add more test cases to cover this case in unit tests and FSC.

#OASIS-7150

@jaeopt jaeopt requested a review from a team as a code owner September 22, 2020 17:49
@coveralls
Copy link

coveralls commented Sep 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 98.847% when pulling fc400ba on jae/bucket into 5d0cf20 on master.

@jaeopt jaeopt merged commit 397d8b5 into master Sep 22, 2020
@jaeopt jaeopt deleted the jae/bucket branch September 22, 2020 20:33
jaeopt added a commit that referenced this pull request Sep 22, 2020
@jaeopt
fix: bucketing error at traffic allocation boundaries (#365)
5d8039f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @aliabbasrizvi