Skip to content

Update DataStore directory on macOS #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 17, 2020
Merged

Conversation

ismailmustafa
Copy link
Contributor

The default save location for the datafile is in the documents directory. This works fine on iOS since it's sandboxed, however, for non-sandboxed applications running on macOS, this results in the following popup showing up:

image

This MR addresses two things:

  1. Changes the data file save location on macOS to be the caches directory. This directory does not require user permission. It is also the directory in which downloadable files should be saved as per Apple's guidelines.
  2. Fixes a compilation error on the macOS target caused by a newly added file that was not added to the macOS target.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 0919abe into optimizely:master Aug 17, 2020
jaeopt pushed a commit that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants