Skip to content

fix(logs): Fixing log messages for Targeted Rollouts and feature variable evaluation. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 17, 2020
Merged

fix(logs): Fixing log messages for Targeted Rollouts and feature variable evaluation. #337

merged 17 commits into from
Jul 17, 2020

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Jun 30, 2020 •
edited
Loading

Summary

Issues

https://optimizely.atlassian.net/browse/OASIS-6670

@yasirfolio3 yasirfolio3 self-assigned this Jun 30, 2020
@msohailhussain msohailhussain changed the title fix(logs): Fixing log messages for Targeted Rollouts. (WIP) fix(logs): Fixing log messages for Targeted Rollouts. Jul 8, 2020
@msohailhussain msohailhussain marked this pull request as ready for review July 8, 2020 19:17
@msohailhussain msohailhussain requested a review from a team as a code owner July 8, 2020 19:17
Base automatically changed from yasir/audit-audience-evaluation to master July 8, 2020 21:20
@yasirfolio3 yasirfolio3 changed the title fix(logs): Fixing log messages for Targeted Rollouts. fix(logs): Fixing log messages for Targeted Rollouts and feature variable evaluation. Jul 9, 2020
@yasirfolio3 yasirfolio3 removed the wip label Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 98.758% when pulling ab6b02b on yasir/log-targeted-rollout into f94e079 on master.

@msohailhussain msohailhussain requested a review from jaeopt July 16, 2020 19:09
jaeopt
jaeopt approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Jul 17, 2020
@jaeopt jaeopt reopened this Jul 17, 2020
@jaeopt jaeopt merged commit 16bf801 into master Jul 17, 2020
@jaeopt jaeopt deleted the yasir/log-targeted-rollout branch July 17, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees

@yasirfolio3 yasirfolio3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yasirfolio3 @coveralls @jaeopt @optimizely-codereview-bot