Add macOS Compatibility #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ismailmustafa thanks for submitting this. Someone will help take a look at this. Can you sign our CLA in https://github.com/optimizely/swift-sdk/blob/master/CONTRIBUTING.md in the interim? |
|
Thanks @aliabbasrizvi, just signed it. |
|
Hey @aliabbasrizvi, any update on the status of this? |
|
@ismailmustafa Your fix looks good. We'll get you updated soon. Thanks for your patience. |
Co-authored-by: Jae Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the changes required to get this working on macOS were minimal. As I'd like to use this SDK on a macOS client I'm working on, I went ahead and made those changes. Let me know if there's anything you'd like me to add/fix/change; happy to do the work.
What I tested:
I tested this on both carthage and SPM. I did not test it on cocoapods, however I made modifications to the podspec based solely on documentation. Would love feedback here if there's anything else I need to do to get cocoapods support.
I did some minimal real world testing on macOS (fetching feature booleans/variables), but not much aside from that. If there's anything you'd like me to test more, please let me know.
Unit Tests:
Since compatibility changes here are minimal, the macOS version of the framework is essentially identical to the iOS version. Not sure what to add in the way of tests, but also happy to add whatever you see fit here.