fix: Targeting rollout should move to fallback rule when bucketing fails. #323
Conversation
| [ | ||
| "variables": [], | ||
| "id": "10389700000", | ||
| "key": kVariationKeyA, |
There was a problem hiding this comment.
Let's use different key names (like "kRolloutVariationKeyA"). It's already used in experiment variations. Can be confused. Same for other rollout variations as well.
| let variation = self.decisionService.getVariationForFeatureRollout(config: config, | ||
| featureFlag: featureFlag, | ||
| userId: kUserId, | ||
| attributes: kAttributesCountryMatch) |
There was a problem hiding this comment.
I think, we need different audience for 2nd rollout rule. CountryMatch is used for feature-experiment. So no guarantee if it's passed down to rollout.
| let variation = self.decisionService.getVariationForFeatureRollout(config: config, | ||
| featureFlag: featureFlag, | ||
| userId: kUserId, | ||
| attributes: kAttributesAgeMatch) |
There was a problem hiding this comment.
With this setting, we cannot tell if it skips the rest of them or goes thru all rules. What about this setting:
Rule1: age < 30 (traffic allocation = 0)
Rule2: age < 40 (traffic allocation = 10000)
Rule3: everybody
When attribute age = 20, we should expect variation for Rule 3 if it skips. Otherwise, variation for Rule 2 will hit.
Summary
Test Plan
Issues