feat: added GetFeatureVariableJSON. #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Apr 23, 2020
Comment on lines
+51
to
+53
| if type == "string" && subType == "json" { | ||
| type = "json" | ||
| } |
There was a problem hiding this comment.
The same mapping should be in the other init() as well?
Comment on lines
+27
to
+34
| enum CodingKeys: String, CodingKey { | ||
| case id | ||
| case key | ||
| case type | ||
| case subType | ||
| case defaultValue | ||
| } | ||
|
|
There was a problem hiding this comment.
We can drop this since all default names
There was a problem hiding this comment.
CodingKeys (Even if exactly the same as defaultNames) are required to be defined if we override init(from decoder: Decoder).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan