Skip to content

fix: (datastore): test cases, switch back to file based backing store for memory datastore. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 30, 2020
Merged

fix: (datastore): test cases, switch back to file based backing store for memory datastore. #311

merged 17 commits into from
Mar 30, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Mar 26, 2020

No description provided.

@jaeopt jaeopt requested a review from a team as a code owner March 26, 2020 23:59
@coveralls
Copy link

coveralls commented Mar 27, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 98.752% when pulling 5d1e22c on jae/data-store-2 into 8b0f324 on master.

@thomaszurkan-optimizely thomaszurkan-optimizely changed the title (wip) test cases fix: (datastore): test cases, switch back to file based backing store for memory datastore. Mar 27, 2020
thomaszurkan-optimizely
thomaszurkan-optimizely previously approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 9811e45 into master Mar 30, 2020
@jaeopt jaeopt deleted the jae/data-store-2 branch March 30, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely