Skip to content

chore: clean up test files in the product bundle #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2020
Merged

chore: clean up test files in the product bundle #295

merged 4 commits into from
Mar 10, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 11, 2020

A few test JSON files wrongly included in the framework bundle. Cleaned them up.

@jaeopt jaeopt requested a review from a team as a code owner February 11, 2020 19:07
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Mar 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 98.702% when pulling e795668 on jae/clean-xcode into e59c9b8 on master.

@jaeopt jaeopt merged commit 2b0dd1e into master Mar 10, 2020
@jaeopt jaeopt deleted the jae/clean-xcode branch March 10, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely