Skip to content

fix(event processor): change ep behavior when timerInterval is negative value #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2019
Merged

fix(event processor): change ep behavior when timerInterval is negative value #268

merged 4 commits into from
Oct 3, 2019

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 27, 2019

  • when timerInterval is negative, spec defines to use default interval value (instead of disabling batch).

@jaeopt jaeopt requested a review from a team as a code owner September 27, 2019 00:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-18.5%) to 74.497% when pulling 7306eef on jae/epDefault into 9814468 on master.

@coveralls
Copy link

coveralls commented Sep 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 95.618% when pulling 9e65566 on jae/epDefault into 9814468 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-18.5%) to 74.497% when pulling 7306eef on jae/epDefault into 9814468 on master.

@jaeopt jaeopt closed this Sep 27, 2019
@jaeopt jaeopt reopened this Sep 27, 2019
@jaeopt jaeopt closed this Sep 30, 2019
@jaeopt jaeopt reopened this Sep 30, 2019
@jaeopt jaeopt closed this Sep 30, 2019
@jaeopt jaeopt reopened this Sep 30, 2019
@jaeopt jaeopt closed this Oct 1, 2019
@jaeopt jaeopt reopened this Oct 1, 2019
@aliabbasrizvi aliabbasrizvi removed the request for review from a team October 2, 2019 19:49
@jaeopt jaeopt merged commit fdc843f into master Oct 3, 2019
@jaeopt jaeopt deleted the jae/epDefault branch October 3, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely