Skip to content

feat: Convert fns module to TS #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

feat: Convert fns module to TS #547

wants to merge 25 commits into from

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Aug 1, 2020

Summary

  • The "what"; a concise description of each logical change
  • Another change

The "why", or other context.

Test plan

Issues

Matt Carroll and others added 25 commits July 31, 2020 18:41
@yavorona
WIP: fallback client
e755af9
@yavorona
Undo fallback client changes
9ba4356
@yavorona
Remove test investigation list
ed7472f
@yavorona
Restore unrelated rollup config changes
91c70de
@yavorona
Remove unrelated eslint change
d3e9741
@yavorona
WIP: unit test support for typescript
d2f0830
@yavorona
Use version of mocha types compatible with our version of mocha
5028195
@yavorona
Consolidate to a single test command, remove esm, set allowJs: true i…
927dc10 
…n tsconfig
@yavorona
Sync exclude/include between rollup and tsconfig. Disable declaration…
10a075c 
… generation. These are to fix UMD build
@yavorona
Enable sourcemaps in tsconfig
1465212
@yavorona
Foo test example for TS
aeb1a3d
@yavorona
Update lint implementation for TypeScript
9230ea2
@yavorona
Undo unrelated
43335bb
@yavorona
Remove duplicate entries in exclude arrays
589809d
@yavorona
Mention Jira number in index.d.ts TODOs
bd9367a
@yavorona
Convert string_value_validator module to TS
ee8eb91
@yavorona
Add ts-loader to karma + webpack configuration, enabling karma tests …
afa540b 
…to work
@yavorona
Convert user_profile_service_validator module to TS (#526)
63d8648
@yavorona
feat: Convert event_tags_validator module to TS (#528)
ce2dab4 
Summary:

Convert event_tags_validator module from JS to TS
Revise user_profile_service_validator module

Test plan:

Existing unit tests
@yavorona
feat: Convert project_config_schema and json_schema_validator modules…
a489529 
… to TS (#524)

* Convert project_config_schema and json_schema_validator modules to TS

* Address Mike's comments

* Update validate function to accept empty object
@yavorona
feat: Convert attributes_validator to TS (#530)
8de8c80 
Summary:

Convert attributes_validator module from JS to TS.

Test plan:

Existing unit tests
@mjc1283 @yavorona
fix(json schema validator): Replace empty object type assertion with …
71b5f35 
…type guard (#545)
@yavorona
Fix configured entry point for json schema validator bundle
0b9fd11
@yavorona
feat: Convert event_tag_utils module to TS (#544)
2a0523b 
* Convert event_tag_utils module to TS

* Convert event_tag_utils module to TS

* Add type guard to avoid using any

* Move 'if (eventTags)' to top level functions

* Move let variables to inside the functions
@yavorona
Convert fns to TS
13701c9
@yavorona yavorona added the WIP label Aug 1, 2020
@yavorona yavorona requested a review from a team as a code owner August 1, 2020 01:42
@yavorona yavorona self-assigned this Aug 1, 2020
@yavorona yavorona closed this Aug 1, 2020
@yavorona yavorona deleted the pnguen/convert-fns-to-ts branch October 20, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yavorona yavorona

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yavorona @mjc1283