Skip to content

fix(ci): Update Node versions used in tests #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2020
Merged

fix(ci): Update Node versions used in tests #469

merged 2 commits into from
May 1, 2020

Conversation

@mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Apr 30, 2020

Summary

Update TravisCI configuration Node versions: remove 6, add 14.

Test plan

Existing tests

@mjc1283 mjc1283 self-assigned this Apr 30, 2020
@mjc1283 mjc1283 changed the title Mcarroll/remove node6 travis fix(ci): Update Node versions used in tests May 1, 2020
@mjc1283 mjc1283 marked this pull request as ready for review May 1, 2020 00:03
@mjc1283 mjc1283 requested a review from a team as a code owner May 1, 2020 00:03
@mjc1283 mjc1283 removed their assignment May 1, 2020
mikeproeng37
mikeproeng37 approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mjc1283 mjc1283 merged commit 7c5a905 into master May 1, 2020
@mjc1283 mjc1283 deleted the mcarroll/remove-node6-travis branch May 1, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjc1283 @mikeproeng37