Skip to content

Update CHANGELOG.MD #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2020
Merged

Update CHANGELOG.MD #443

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0d256f
Update CHANGELOG.MD
yavorona Apr 6, 2020
7391bcd
Address Ali's comments
yavorona Apr 6, 2020
a8ef7c6
Address comments
yavorona Apr 6, 2020
2ac2394
Move new changes under "Breaking Changes"
yavorona Apr 8, 2020
a596cf5
Merge branch 'master' into pnguen-pr442
yavorona Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,23 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Breaking Changes:
- Removed `Promise` polyfill from browser entry point ([417](https://github.com/optimizely/javascript-sdk/pull/417))

### New Features
Copy link
Contributor

@mjc1283 mjc1283 Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this under ### Breaking Changes, not ### New Features.


- Changed functionality of JSON schema validation in all entry points ([442](https://github.com/optimizely/javascript-sdk/pull/442)).
- Previously, `skipJSONValidation` flag was used by the user to specify whether the JSON object should be validated.
- Now, `skipJSONValidation` has been removed entirely from all entry points. Instead, a user will need to import `jsonSchemaValidator` from `@optimizely/optimizely-sdk/lib/utils/json_schema_validator` and pass it to `createInstance` to perform validation as shown below:

```js
const optimizelySDK = require('@optimizely/optimizely-sdk');
const jsonSchemaValidator = require('@optimizely/optimizely-sdk/lib/utils/json_schema_validator');

// Require JSON schema validation for the datafile
var optimizelyClientInstance = optimizely.createInstance({
datafile: datafile,
jsonSchemaValidator: jsonSchemaValidator,
});
```

## [3.6.0-alpha.1] - March 4, 2020

### New Features
Expand Down