Skip to content

Removed dependency on lodash.isNumber #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2020
Merged

Removed dependency on lodash.isNumber #407

merged 2 commits into from
Feb 24, 2020

Conversation

@fayyazarshad
Copy link
Contributor

@fayyazarshad fayyazarshad commented Feb 20, 2020 •
edited
Loading

Summary

to reduce package size, we are trying to gradually get rid of lodash library. This PR replaces isNumber function with simple implementation for numbers and strings.

Test plan

Added unit tests

@fayyazarshad fayyazarshad self-assigned this Feb 20, 2020
@coveralls
Copy link

coveralls commented Feb 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.562% when pulling 9aa08c4 on fayyaz/replace_lodash_isNumber into ee5a24d on master.

@fayyazarshad fayyazarshad marked this pull request as ready for review February 20, 2020 07:04
@fayyazarshad fayyazarshad requested a review from a team as a code owner February 20, 2020 07:04
@zashraf1985 zashraf1985 changed the title Removed isNumber method on lodash.isNumber Removed dependency on lodash.isNumber Feb 20, 2020
@fayyazarshad fayyazarshad self-assigned this Feb 20, 2020
mjc1283
mjc1283 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, LGTM

@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_isNumber branch 2 times, most recently from 042870d to 9aa08c4 Compare February 24, 2020 05:38
@fayyazarshad fayyazarshad reopened this Feb 24, 2020
@fayyazarshad fayyazarshad reopened this Feb 24, 2020
@mjc1283 mjc1283 merged commit 31b5a4d into master Feb 24, 2020
@mjc1283 mjc1283 deleted the fayyaz/replace_lodash_isNumber branch February 24, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mjc1283 mjc1283 mjc1283 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fayyazarshad fayyazarshad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fayyazarshad @coveralls @mjc1283