Skip to content

refactor: Removed dependency on lodash.values #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 25, 2020
Merged

refactor: Removed dependency on lodash.values #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d75a041
replaced lodash values function with Object.values
zashraf1985 Feb 15, 2020
2e063cd
replaced with Object.keys because Object.values is not available in n…
zashraf1985 Feb 15, 2020
ba36b7e
fixed lint
zashraf1985 Feb 15, 2020
b151ccf
using objectValues from js sdk utils
zashraf1985 Feb 18, 2020
5bf3984
Fixed lint error
zashraf1985 Feb 18, 2020
46b40ea
Merge branch 'master' into zeeshan/replace_lodash_values
zashraf1985 Feb 19, 2020
08bf0d2
Merge branch 'master' into zeeshan/replace_lodash_values
zashraf1985 Feb 20, 2020
139cf4b
Merge branch 'master' into zeeshan/replace_lodash_values
mjc1283 Feb 21, 2020
e78b60a
Merge branch 'master' into zeeshan/replace_lodash_values
zashraf1985 Feb 22, 2020
fa6343b
removed fns.values altogether. using objectValues from js sdk utils d…
zashraf1985 Feb 22, 2020
e8bc418
Merge branch 'master' into zeeshan/replace_lodash_values
zashraf1985 Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/optimizely-sdk/lib/core/notification_center/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var sprintf = require('@optimizely/js-sdk-utils').sprintf;
var jsSdkUtils = require('@optimizely/js-sdk-utils');

var LOG_LEVEL = enums.LOG_LEVEL;
var LOG_MESSAGES = enums.LOG_MESSAGES;
Expand Down Expand Up @@ -55,7 +55,7 @@ function NotificationCenter(options) {
*/
NotificationCenter.prototype.addNotificationListener = function (notificationType, callback) {
try {
var isNotificationTypeValid = fns.values(enums.NOTIFICATION_TYPES)
var isNotificationTypeValid = jsSdkUtils.objectValues(enums.NOTIFICATION_TYPES)
.indexOf(notificationType) > -1;
if (!isNotificationTypeValid) {
return -1;
Expand Down Expand Up @@ -165,7 +165,7 @@ NotificationCenter.prototype.sendNotifications = function (notificationType, not
try {
callback(notificationData);
} catch (ex) {
this.logger.log(LOG_LEVEL.ERROR, sprintf(LOG_MESSAGES.NOTIFICATION_LISTENER_EXCEPTION, MODULE_NAME, notificationType, ex.message));
this.logger.log(LOG_LEVEL.ERROR, jsSdkUtils.sprintf(LOG_MESSAGES.NOTIFICATION_LISTENER_EXCEPTION, MODULE_NAME, notificationType, ex.message));
}
}.bind(this));
} catch (e) {
Expand Down
1 change: 0 additions & 1 deletion packages/optimizely-sdk/lib/utils/fns/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module.exports = {
uuid: function() {
return uuid.v4();
},
values: require('lodash/values'),
isNumber: function(value) {
return typeof value === 'number';
},
Expand Down