Skip to content

speed up local build time by 97% #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 10, 2017
Merged

speed up local build time by 97% #82

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
075fb31
skip the exhaustive `generateBucketValueDistribution` when we're not
wangjoshuah Mar 10, 2017
68306da
use system property so changes are compatible with java 1.6 and java 1.7
wangjoshuah Mar 10, 2017
95d2fec
Check for ENV variable set to true by default by travis.
wangjoshuah Mar 10, 2017
66fa8ef
verify test runs on Travis CI
wangjoshuah Mar 10, 2017
2219b46
check ci value on travis
wangjoshuah Mar 10, 2017
06f6f9e
show log streams in travis
wangjoshuah Mar 10, 2017
4b742e9
log into travis our bucketvaluedistribution test
wangjoshuah Mar 10, 2017
a7b40be
use exhaustive test for gradles
wangjoshuah Mar 10, 2017
5268486
remove false assert
wangjoshuah Mar 10, 2017
00d49fc
revert wildcard imports
wangjoshuah Mar 10, 2017
d708acb
change things back to normal
wangjoshuah Mar 10, 2017
57abf07
fix nit
wangjoshuah Mar 10, 2017
0ea8cba
fix nit
wangjoshuah Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions core-api/src/test/java/com/optimizely/ab/bucketing/BucketerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,38 +16,29 @@
*/
package com.optimizely.ab.bucketing;

import ch.qos.logback.classic.Level;
import com.optimizely.ab.bucketing.internal.MurmurHash3;
import com.optimizely.ab.categories.ExhaustiveTest;
import com.optimizely.ab.config.Experiment;
import com.optimizely.ab.config.ProjectConfig;
import com.optimizely.ab.config.TrafficAllocation;
import com.optimizely.ab.config.Variation;
import com.optimizely.ab.internal.LogbackVerifier;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.junit.Assume;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.rules.ExpectedException;

import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.*;
Copy link
Contributor

@vraja2 vraja2 Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use explicit imports

import java.util.concurrent.atomic.AtomicInteger;

import ch.qos.logback.classic.Level;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import static com.optimizely.ab.config.ProjectConfigTestUtils.validProjectConfigV2;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.junit.Assert.*;
Copy link
Contributor

@vraja2 vraja2 Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit imports

import static org.mockito.Mockito.*;

/**
* Tests for {@link Bucketer}.
Expand Down Expand Up @@ -79,6 +70,7 @@ public void generateBucketValueForNegativeHashCodes() throws Exception {
@Test
@Category(ExhaustiveTest.class)
public void generateBucketValueDistribution() throws Exception {
Assume.assumeTrue(System.getenv("CI").equals("true"));
long lowerHalfCount = 0;
long totalCount = 0;
int outOfRangeCount = 0;
Expand Down