[FSSDK-9041] chore: upgrade dependency versions #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
approved these changes
Jun 5, 2023
mikechu-optimizely
left a comment
mikechu-optimizely
left a comment
There was a problem hiding this comment.
Only a small question/thought, but LGTM.
| @@ -1 +0,0 @@ | |||
| httpClientVersion = 4.5.13 | |||
There was a problem hiding this comment.
Just checking (perhaps automatic): Did you intend to remove (vs upgrade) this entry? Can we delete the file if it's going to be empty?
| jsonSimpleVersion = 1.1.1 | ||
| logbackVersion = 1.2.3 | ||
| slf4jVersion = 1.7.30 | ||
| httpClientVersion = 4.5.14 |
There was a problem hiding this comment.
Oh, maybe it was an upgrade and move 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade dependency versions to clear source clear warnings
Test plan
Issues