Skip to content

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 9, 2023

Summary

When vuid is used as userId, graphQL fetch segments api should be called with "vuid" as a query identifier.

Test plan

  • Unit test validating "vuid" as a query identifier.

Issues

@jaeopt jaeopt requested a review from a team as a code owner February 9, 2023 19:47
@jaeopt jaeopt removed their assignment Feb 9, 2023
@jaeopt jaeopt requested a review from mnoman09 February 9, 2023 19:49
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit c7f9099 into master Feb 10, 2023
@jaeopt jaeopt deleted the jae/vuid-fetch-segments branch February 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants