Skip to content

fix: Fixed ODP Event type and Json Parser log levels #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: Fixed ODP Event type and Json Parser log levels #495

merged 1 commit into from
Dec 21, 2022

Conversation

@zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Dec 15, 2022

Summary

  1. Changed default event type from client_initialized to identified.
  2. Changed Parser log levels from info to debug.

Test plan

  • Manually tested thoroughly.
  • All existing unit tests and FSC test pass.

Issues

https://jira.sso.episerver.net/browse/FSSDK-8725
https://jira.sso.episerver.net/browse/FSSDK-8726

@zashraf1985
1. Changed default event type from client_initialized to identified.
019471e 
2. Changed Parser log levels from info to debug.
@zashraf1985 zashraf1985 requested a review from a team as a code owner December 15, 2022 04:13
@zashraf1985 zashraf1985 removed their assignment Dec 15, 2022
jaeopt
jaeopt approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit 3c14dde into master Dec 21, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/ats-bugs-FSSDK-8726-FSSDK-8726 branch December 21, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

No one assigned

Labels

🤖 8 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zashraf1985 @jaeopt @optimizely-codereview-bot