Skip to content

move validate forced decision to decision service #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2022
Merged

move validate forced decision to decision service #457

merged 3 commits into from
Jan 5, 2022

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 29, 2021

Summary

  • Moves findValidatedForcedDecision method to decision service as validatedForcedDecision

Test plan

All unit test and FSC tests should pass.

@mnoman09 mnoman09 requested a review from a team as a code owner December 29, 2021 15:42
@coveralls
Copy link

coveralls commented Dec 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1920

  • 25 of 29 (86.21%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 90.735%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java 7 8 87.5%
core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java 17 20 85.0%
Totals Coverage Status
Change from base Build 1914: 0.002%
Covered Lines: 4867
Relevant Lines: 5364
💛 - Coveralls

dustin-sier
dustin-sier approved these changes Dec 30, 2021
View reviewed changes
Copy link

@dustin-sier dustin-sier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The-inside-man
The-inside-man approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@msohailhussain msohailhussain merged commit 7298cf5 into master Jan 5, 2022
@msohailhussain msohailhussain deleted the mnoman/ValidateForcedDecisionMove branch January 5, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@dustin-sier dustin-sier dustin-sier approved these changes

+1 more reviewer

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mnoman09 @coveralls @The-inside-man @jaeopt @dustin-sier @msohailhussain @NomanShoaib