Skip to content

chore: clean up datafile version log message #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2021
Merged

chore: clean up datafile version log message #447

merged 2 commits into from
Oct 4, 2021

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Sep 20, 2021

Summary

  • When datafile is parsed first time, it returns "null" for the previous version. The log message with "null previous version" can be confusing. Clean it up.

Issues

  • "OASIS-7388"

@jaeopt jaeopt requested a review from a team as a code owner September 20, 2021 18:26
@jaeopt jaeopt removed their assignment Sep 20, 2021
The-inside-man
The-inside-man approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaeopt jaeopt merged commit 6297445 into master Oct 4, 2021
@jaeopt jaeopt deleted the jae/null-version branch October 4, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 24 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaeopt @The-inside-man @optimizely-codereview-bot