Skip to content

fix: close the closable response. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2021
Merged

fix: close the closable response. #419

merged 4 commits into from
Feb 3, 2021

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jan 23, 2021

Summary

  • close the closable response from apache httpclient.

Test plan

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner January 23, 2021 00:55
@coveralls
Copy link

coveralls commented Jan 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1660

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java 5 7 71.43%
Totals Coverage Status
Change from base Build 1659: -0.03%
Covered Lines: 4456
Relevant Lines: 4954
💛 - Coveralls

jaeopt
jaeopt approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Feb 3, 2021
@jaeopt jaeopt reopened this Feb 3, 2021
@jaeopt jaeopt merged commit 5a09786 into master Feb 3, 2021
@jaeopt jaeopt deleted the closeCloseableResource branch February 3, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mjc1283 mjc1283 Awaiting requested review from mjc1283

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomaszurkan-optimizely @coveralls @jaeopt