Skip to content

chore: fix sample codes to use decide apis #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2020
Merged

chore: fix sample codes to use decide apis #414

merged 2 commits into from
Dec 15, 2020

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Dec 15, 2020

Summary

  • Fix sample codes from legacy APIs to new decide APIs

@jaeopt jaeopt requested a review from a team as a code owner December 15, 2020 17:54
@jaeopt jaeopt removed their assignment Dec 15, 2020
msohailhussain
msohailhussain approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Dec 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1630

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 89.693%
Changes Missing Coverage Covered Lines Changed/Added Lines %
java-quickstart/src/main/java/com/optimizely/Example.java 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
java-quickstart/src/main/java/com/optimizely/Example.java 1 0%
Totals Coverage Status
Change from base Build 1625: -0.05%
Covered Lines: 4412
Relevant Lines: 4919
💛 - Coveralls

@jaeopt jaeopt merged commit 08e5ae8 into master Dec 15, 2020
@jaeopt jaeopt deleted the jae/fix-examples branch December 15, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaeopt @coveralls @msohailhussain