Skip to content

chore: prepare for 3.7.0 release #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2020
Merged

chore: prepare for 3.7.0 release #411

merged 3 commits into from
Nov 20, 2020

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Nov 20, 2020

Summary

  • Prepare for 3.7.0 release

@jaeopt jaeopt requested a review from a team as a code owner November 20, 2020 19:38
@jaeopt jaeopt removed their assignment Nov 20, 2020
thomaszurkan-optimizely
thomaszurkan-optimizely suggested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off until we patch http-client with a later version?

@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1610

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.75%
Totals Coverage Status
Change from base Build 1604: 0.0%
Covered Lines: 4133
Relevant Lines: 4605
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.75%
Totals Coverage Status
Change from base Build 1604: 0.0%
Covered Lines: 4133
Relevant Lines: 4605
💛 - Coveralls

@jaeopt
Copy link
Contributor Author

jaeopt commented Nov 20, 2020

@thomaszurkan-optimizely @pawels-optimizely
Not sure about the schedule. When do you expect it's ready?

@thomaszurkan-optimizely
Copy link
Contributor

thomaszurkan-optimizely commented Nov 20, 2020

@thomaszurkan-optimizely @pawels-optimizely
Not sure about the schedule. When do you expect it's ready?

https://github.com/optimizely/java-sdk/blob/master/core-httpclient-impl/gradle.properties
bump patch to 13. httpClientVersion = 4.5.13

@jaeopt jaeopt merged commit db5b0e0 into master Nov 20, 2020
@jaeopt jaeopt deleted the prepare-3.7.0 branch November 20, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaeopt @coveralls @thomaszurkan-optimizely @pawels-optimizely