Skip to content

(chore): update for new release for android support #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2019
Merged

(chore): update for new release for android support #341

merged 1 commit into from
Oct 11, 2019

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Oct 11, 2019

Summary

  • We have added support for older versions of Android (under API 24) by not using java.util.Supplier which is not supported in java 8 on these older versions. Change log update for release of 3.3.1

Test plan

Change log change.

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner October 11, 2019 19:47
mikeproeng37
mikeproeng37 approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.818%
Totals Coverage Status
Change from base Build 1221: 0.0%
Covered Lines: 18040
Relevant Lines: 20085
💛 - Coveralls

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 2cddbac into master Oct 11, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the prepareFor331 branch October 11, 2019 20:19
thomaszurkan-optimizely added a commit that referenced this pull request Oct 11, 2019
@thomaszurkan-optimizely
update for new release for android support (#341)
642d024
thomaszurkan-optimizely added a commit that referenced this pull request Oct 11, 2019
@thomaszurkan-optimizely
(chore): chrerry pick changes to 3.3.x. (#342)
38d6606 
* (fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. (#340)

* use a ParserSupplier to enable work on older versions of Android.

* remove the generics

* update for new release for android support (#341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikecdavis mikecdavis Awaiting requested review from mikecdavis

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomaszurkan-optimizely @coveralls @mikeproeng37