Skip to content

(fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

(fix): use a ParserSupplier instead of java.util.Supplier to enable work on older versions of Android. #340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
801056f
use a ParserSupplier to enable work on older versions of Android.
thomaszurkan-optimizely Oct 10, 2019
d059530
remove the generics
thomaszurkan-optimizely Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions core-api/src/main/java/com/optimizely/ab/config/parser/DefaultConfigParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ public static ConfigParser getInstance() {
}

//======== Helper methods ========//
@FunctionalInterface
public interface ParserSupplier {

/**
* Gets a result.
*
* @return a result
*/
ConfigParser get();
}

public enum ConfigParserSupplier {
// WARNING THESE MUST REMAIN LAMBDAS!!!
Expand All @@ -49,9 +59,9 @@ public enum ConfigParserSupplier {
JSON_SIMPLE_CONFIG_PARSER("org.json.simple.JSONObject", () -> { return new JsonSimpleConfigParser(); });

private final String className;
private final Supplier<ConfigParser> supplier;
private final ParserSupplier supplier;

ConfigParserSupplier(String className, Supplier<ConfigParser> supplier) {
ConfigParserSupplier(String className, ParserSupplier supplier) {
this.className = className;
this.supplier = supplier;
}
Expand Down