Add clear deprecation path from factory builder method. #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1171
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1171
💛 - Coveralls |
thomaszurkan-optimizely
approved these changes
Aug 8, 2019
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
LGTM. Unit test?
Contributor
Author
|
there are already unit tests when |
mikecdavis
pushed a commit
that referenced
this pull request
Aug 19, 2019
mikecdavis
pushed a commit
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizely.Builder#withDatafilepublic.This should get patched into version
3.2.1and will allow the Android SDK to cleanly use non-deprecated methods.