Skip to content

Catch errors thrown while sending notifications. #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

Catch errors thrown while sending notifications. #295

merged 1 commit into from
May 6, 2019

Conversation

@mikecdavis
Copy link
Contributor

@mikecdavis mikecdavis commented May 6, 2019

Summary

  • Catch all exceptions thrown from NotificationHandlers.

This fixes a regression in #288 refactor when a NotificationHandler throws an error.

@mikecdavis mikecdavis requested a review from aliabbasrizvi May 6, 2019 20:20
aliabbasrizvi
aliabbasrizvi approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 1023

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.068%
Totals Coverage Status
Change from base Build 1020: 0.01%
Covered Lines: 3088
Relevant Lines: 3467
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 1023

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.068%
Totals Coverage Status
Change from base Build 1020: 0.01%
Covered Lines: 3088
Relevant Lines: 3467
💛 - Coveralls

@aliabbasrizvi
Copy link
Contributor

aliabbasrizvi commented May 6, 2019

Confirmed that unit tests and compatibility suite tests are passing.

@aliabbasrizvi aliabbasrizvi merged commit 9461d1e into master May 6, 2019
aliabbasrizvi pushed a commit that referenced this pull request May 6, 2019
@aliabbasrizvi
Catch errors thrown while sending notifications. (#295)
085ad7c
@mikecdavis mikecdavis deleted the mikecdavis/catch-listener-errors branch May 8, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikecdavis @coveralls @aliabbasrizvi