Skip to content

(fix): fix example by creating new user each time so that events can be done… #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

(fix): fix example by creating new user each time so that events can be done… #257

merged 1 commit into from
Jan 23, 2019

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jan 23, 2019

… multiple times

Summary

Fix quickstart by adding random user id each time it is run.

  • If you want to see multiple events the user id should be different.

@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 847

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.616%
Totals Coverage Status
Change from base Build 838: 0.0%
Covered Lines: 2684
Relevant Lines: 2995
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit f9de142 into master Jan 23, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the quickStartFix branch January 23, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomaszurkan-optimizely @coveralls @mikeproeng37