Skip to content

Sorted enabledFeaturesList and added its unit test #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

Sorted enabledFeaturesList and added its unit test #173

merged 1 commit into from
Mar 16, 2018

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Mar 7, 2018

No description provided.

@optibot
Copy link

optibot commented Mar 7, 2018

Can one of the admins verify this patch?

@mnoman09 mnoman09 self-assigned this Mar 7, 2018
@coveralls
Copy link

coveralls commented Mar 7, 2018

Pull Request Test Coverage Report for Build 477

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 88.736%
Totals Coverage Status
Change from base Build 476: 0.005%
Covered Lines: 2198
Relevant Lines: 2477
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 7, 2018

Pull Request Test Coverage Report for Build 477

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 88.736%
Totals Coverage Status
Change from base Build 476: 0.005%
Covered Lines: 2198
Relevant Lines: 2477
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

mikeproeng37 commented Mar 8, 2018

build

@mikeproeng37 mikeproeng37 merged commit cde9777 into master Mar 16, 2018
@msohailhussain msohailhussain deleted the sohail/sortedEnabledFeaturePR branch May 21, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mnoman09 @optibot @coveralls @mikeproeng37