patch user attribute evaluation #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and experiment using it in the parser
Contributor
Author
|
build |
1 similar comment
Contributor
Author
|
build |
aliabbasrizvi
approved these changes
Nov 7, 2017
thomaszurkan-optimizely
pushed a commit
that referenced
this pull request
Dec 12, 2017
* patch evaluation by using equals * make value optional in the UserAttribute class. Add malformed audience and experiment using it in the parser * add test for null value evaluation. add audience to experiment * add test for evaluating audience with missing condition value
Contributor
|
@wangjoshuah @aliabbasrizvi do you remember why we made this change? AFAIK the datafile's audience conditions should always include non-null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.