Merge master onto 2.0.x for beta2 release #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wangjoshuah
commented
Oct 6, 2017
wangjoshuah
commented
- if no live variable usage exists for the variable in the variation, return the default value
- add rollout with variation that does not change variable value in rollout rule. This means no live variable usage will be in datafile. need to fallback on default value
- add test to make sure we fall back on default value when variable usage not found in datafile
* if no live variable usage exists for the variable in the variation, return the default value * add rollout with variation that does not change variable value in rollout rule. This means no live variable usage will be in datafile. need to fallback on default value * add test to make sure we fall back on default value when variable usage not found in datafile
wangjoshuah
changed the title
…umbers after semver tags (#151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.