-
Notifications
You must be signed in to change notification settings - Fork 32
use trusty distribution #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7663b0a to
1a43741
Compare
core-api/build.gradle
Outdated
| provided group: 'org.json', name: 'json', version: jsonVersion, optional | ||
| provided group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion, optional | ||
| provided group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion, optional | ||
| compile group: 'com.google.code.gson', name: 'gson', version: gsonVersion, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing these to compile will result in all of these JSON libraries being packaged with the SDK which will increase bloat. provided was used to give that dependency flexibility to the consumer.
.travis.yml
Outdated
| language: java | ||
| dist: precise | ||
| dist: trusty | ||
| sudo: required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we need root privileges?
| dist: trusty | ||
| sudo: required | ||
| jdk: | ||
| - openjdk7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think openjdk7 should still be supported.
|
@vraja2 travis-ci.org is ending support for The |
Upgrade travis-ci
travis.ymlto usetrustydistribution since that is their new standard.The gradle version of their linux distribution is gradle
4.0.1so I upgraded our gradle wrapper to that.That required we upgrade our nebula dependency to
3.2.0.Drop support for JDK 7 until travis-ci can fix that.