Skip to content

feature variable accessor apis #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2017
Merged

feature variable accessor apis #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
534cf64
add unit tests for getFeatureVariableString calling through to intern…
wangjoshuah Aug 15, 2017
177bf24
link feature variable accessors to feature variable by value and type…
wangjoshuah Aug 15, 2017
2353651
catch number format exception for parsing integer and double
wangjoshuah Aug 16, 2017
2e61284
add tests to check we catch exception
wangjoshuah Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions core-api/src/main/java/com/optimizely/ab/Optimizely.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,16 @@ public void track(@Nonnull String eventName,
@Nonnull String variableKey,
@Nonnull String userId,
@Nonnull Map<String, String> attributes) {
String variableValue = getFeatureVariableValueForType(
featureKey,
variableKey,
userId,
attributes,
LiveVariable.VariableType.BOOLEAN
);
if (variableValue != null) {
return Boolean.parseBoolean(variableValue);
}
return null;
}

Expand Down Expand Up @@ -413,6 +423,22 @@ public void track(@Nonnull String eventName,
@Nonnull String variableKey,
@Nonnull String userId,
@Nonnull Map<String, String> attributes) {
String variableValue = getFeatureVariableValueForType(
featureKey,
variableKey,
userId,
attributes,
LiveVariable.VariableType.DOUBLE
);
if (variableValue != null) {
try {
return Double.parseDouble(variableValue);
}
catch (NumberFormatException exception) {
logger.error("NumberFormatException while trying to parse \"" + variableValue +
"\" as Double. " + exception);
}
}
return null;
}

Expand Down Expand Up @@ -443,6 +469,22 @@ public void track(@Nonnull String eventName,
@Nonnull String variableKey,
@Nonnull String userId,
@Nonnull Map<String, String> attributes) {
String variableValue = getFeatureVariableValueForType(
featureKey,
variableKey,
userId,
attributes,
LiveVariable.VariableType.INTEGER
);
if (variableValue != null) {
try {
return Integer.parseInt(variableValue);
}
catch (NumberFormatException exception) {
logger.error("NumberFormatException while trying to parse \"" + variableValue +
"\" as Integer. " + exception.toString());
}
}
return null;
}

Expand Down
Loading