Skip to content

make status optional in the creation of live variables #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2017
Merged

make status optional in the creation of live variables #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core-api/src/main/java/com/optimizely/ab/config/LiveVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ public LiveVariable(@JsonProperty("id") String id,
this.id = id;
this.key = key;
this.defaultValue = defaultValue;
this.status = status;
if (status == null) {
this.status = VariableStatus.ACTIVE;
}
else {
this.status = status;
}
this.type = type;
}

Expand Down
12 changes: 6 additions & 6 deletions core-api/src/test/java/com/optimizely/ab/config/ValidProjectConfigV4.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public class ValidProjectConfigV4 {
VARIABLE_DOUBLE_VARIABLE_ID,
VARIABLE_DOUBLE_VARIABLE_KEY,
VARIABLE_DOUBLE_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.DOUBLE
);
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_DOUBLE = new FeatureFlag(
Expand All @@ -95,7 +95,7 @@ public class ValidProjectConfigV4 {
VARIABLE_INTEGER_VARIABLE_ID,
VARIABLE_INTEGER_VARIABLE_KEY,
VARIABLE_INTEGER_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.INTEGER
);
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_INTEGER = new FeatureFlag(
Expand All @@ -116,7 +116,7 @@ public class ValidProjectConfigV4 {
VARIABLE_BOOLEAN_VARIABLE_ID,
VARIABLE_BOOLEAN_VARIABLE_KEY,
VARIABLE_BOOLEAN_VARIABLE_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.BOOLEAN
);
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_BOOLEAN = new FeatureFlag(
Expand All @@ -137,7 +137,7 @@ public class ValidProjectConfigV4 {
VARIABLE_STRING_VARIABLE_ID,
VARIABLE_STRING_VARIABLE_KEY,
VARIABLE_STRING_VARIABLE_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.STRING
);
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_STRING = new FeatureFlag(
Expand All @@ -158,7 +158,7 @@ public class ValidProjectConfigV4 {
VARIABLE_FIRST_LETTER_ID,
VARIABLE_FIRST_LETTER_KEY,
VARIABLE_FIRST_LETTER_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.STRING
);
private static final String VARIABLE_REST_OF_NAME_ID = "4052219963";
Expand All @@ -168,7 +168,7 @@ public class ValidProjectConfigV4 {
VARIABLE_REST_OF_NAME_ID,
VARIABLE_REST_OF_NAME_KEY,
VARIABLE_REST_OF_NAME_DEFAULT_VALUE,
LiveVariable.VariableStatus.ACTIVE,
null,
LiveVariable.VariableType.STRING
);
private static final FeatureFlag FEATURE_FLAG_MULTI_VARIATE_FEATURE = new FeatureFlag(
Expand Down