Skip to content

fix: instantiate event processor with dispatcher #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2020
Merged

fix: instantiate event processor with dispatcher #239

merged 7 commits into from
Mar 3, 2020

Conversation

@pawels-optimizely
Copy link
Contributor

@pawels-optimizely pawels-optimizely commented Mar 2, 2020 •
edited
Loading

Summary

  • before dispatcher was initialized in go routine, which was wrong.
  • now dispatcher is initialized in constructor, and just ticker starts in go routine.

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner March 2, 2020 19:36
@pawels-optimizely pawels-optimizely removed their assignment Mar 3, 2020
@pawels-optimizely pawels-optimizely merged commit 60eeead into master Mar 3, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/OASIS-6022 branch March 3, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

1 more reviewer

@mjc1283 mjc1283 mjc1283 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawels-optimizely @mjc1283