feat: Datafile parsing + audience evaluation for ODP integration #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
changed the title
msohailhussain
suggested changes
Jul 22, 2022
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
i just did coding review not functional review.
jaeopt
requested changes
Aug 2, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Most changes look good. We see public getter/setter for qualifiedSegments missing in OptimizelyUserContext. I also see several "deprecation" github warnings. Is this normal?
OptimizelySDK.Tests/AudienceConditionsTests/ConditionEvaluationTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jae Kim <[email protected]>
Co-authored-by: Jae Kim <[email protected]>
Contributor
Author
@jaeopt The deprecation warnings need a separate chore+PR to resolve in my opinion. |
jaeopt
requested changes
Aug 2, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good! A small change suggested and a clarification.
mikechu-optimizely
deleted the
mike/datafile-parsing-audience-evaluation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
integrationssection of the datafileEvaluate()using UserContextTest plan
Run full
OptimizelySDK.Testsproject/suiteIssues