Skip to content

fix: DefaultErrorHandler shouldn't raise exception #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix: DefaultErrorHandler shouldn't raise exception #260

merged 1 commit into from
Mar 17, 2021

Conversation

@msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Mar 16, 2021

Summary

  • When no ErrorHandler is provided in the HttpProjectConfigManager, it provides DefaultErrorHandler that raise exception without providing any argument.
  • Fixed by explicitly setting throwException=false in the constructor.

Test plan

  • Added a unit test.
  • All FSC should be passed.

@msohailhussain msohailhussain requested a review from a team as a code owner March 16, 2021 18:30
@msohailhussain msohailhussain removed their assignment Mar 16, 2021
jaeopt
jaeopt approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit e525e8c into master Mar 17, 2021
@jaeopt jaeopt deleted the sohail/experimentKeyException branch March 17, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msohailhussain @jaeopt