Skip to content

Feat: Added unit tests for reasons addInfo logs #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2021
Merged

Feat: Added unit tests for reasons addInfo logs #254

merged 3 commits into from
Jan 19, 2021

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 11, 2020

Summary

  • Added few unit tests to test that DecisionReasons contains the info logs upon setting decideOption as INCLUDE_REASONS

Test plan

It should pass with FSC and all unit tests should pass

@mnoman09 mnoman09 requested a review from a team as a code owner December 11, 2020 16:20
jaeopt
jaeopt approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 6d60cf3 into master Jan 19, 2021
@jaeopt jaeopt deleted the mnoman/ReasonsInfoTests branch January 19, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnoman09 @jaeopt