Skip to content

fix: error handler not raise exception while using optimizelyfactory #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2020
Merged

fix: error handler not raise exception while using optimizelyfactory #241

merged 3 commits into from
Sep 15, 2020

Conversation

@msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Sep 2, 2020 •
edited
Loading

Summary

  • NewDefaultInstance shouldn't cause optimizely instance to raise exception while handling error, by default all DefaultErrorHandler shouldn't raise exception.
  • Passed logger in default error handler and made raise exception to false.

Test plan

@msohailhussain msohailhussain requested a review from a team as a code owner September 2, 2020 19:44
@msohailhussain msohailhussain removed their assignment Sep 2, 2020
@msohailhussain msohailhussain reopened this Sep 3, 2020
@msohailhussain msohailhussain removed their assignment Sep 9, 2020
mikeproeng37
mikeproeng37 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 reopened this Sep 14, 2020
@mikeproeng37 mikeproeng37 merged commit 4dd55e2 into master Sep 15, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/emptydffix branch September 15, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@msohailhussain msohailhussain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msohailhussain @mikeproeng37 @optimizely-codereview-bot