Skip to content

fix: improved logging #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

fix: improved logging #227

merged 2 commits into from
Jul 7, 2020

Conversation

@msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Jul 6, 2020

Summary

  • Improved logs while polling data or exception is raised.

Test plan

  • Added unit test and verified logging.
  • No impact on integration test. Must pass.

@msohailhussain msohailhussain requested a review from a team as a code owner July 6, 2020 19:22
@msohailhussain msohailhussain removed their assignment Jul 6, 2020
mikeproeng37
mikeproeng37 approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit f180b62 into master Jul 7, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/csharp_logging branch July 7, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msohailhussain @mikeproeng37