-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 tilt: delete at correct index to remove --leader-elect flag for catalogd #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 tilt: delete at correct index to remove --leader-elect flag for catalogd #2127
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 78 78
Lines 7260 7260
=======================================
Hits 5343 5343
Misses 1567 1567
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve 🤷 |
tmshort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The intention of the tilt-local-dev patches is to delete the --leader-elect flags in catalogd and operator-controller. In the kustomize reshuffling, it looks like flags moved around, but the tilt patch was not updated to use the correct index for deletion.
This fixes that.
Reviewer Checklist