Skip to content

Minor fix: optimize var usage #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Minor fix: optimize var usage #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ public UpdateControl<WebPage> reconcile(WebPage webPage, Context context) {
}

String ns = webPage.getMetadata().getNamespace();
String configMapName = configMapName(webPage);
String deploymentName = deploymentName(webPage);

Map<String, String> data = new HashMap<>();
data.put("index.html", webPage.getSpec().getHtml());
Expand All @@ -46,30 +48,31 @@ public UpdateControl<WebPage> reconcile(WebPage webPage, Context context) {
new ConfigMapBuilder()
.withMetadata(
new ObjectMetaBuilder()
.withName(configMapName(webPage))
.withName(configMapName)
.withNamespace(ns)
.build())
.withData(data)
.build();

Deployment deployment = loadYaml(Deployment.class, "deployment.yaml");
deployment.getMetadata().setName(deploymentName(webPage));
deployment.getMetadata().setName(deploymentName);
deployment.getMetadata().setNamespace(ns);
deployment.getSpec().getSelector().getMatchLabels().put("app", deploymentName(webPage));
deployment.getSpec().getSelector().getMatchLabels().put("app", deploymentName);

deployment
.getSpec()
.getTemplate()
.getMetadata()
.getLabels()
.put("app", deploymentName(webPage));
.put("app", deploymentName);
deployment
.getSpec()
.getTemplate()
.getSpec()
.getVolumes()
.get(0)
.setConfigMap(
new ConfigMapVolumeSourceBuilder().withName(configMapName(webPage)).build());
new ConfigMapVolumeSourceBuilder().withName(configMapName).build());

Service service = loadYaml(Service.class, "service.yaml");
service.getMetadata().setName(serviceName(webPage));
Expand Down