Skip to content

fix: prevent double registration of same CR with different controllers #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: prevent double registration of same CR with different controllers #627

merged 1 commit into from
Oct 27, 2021

Conversation

metacosm
Copy link
Collaborator

Fixes #626

@metacosm metacosm merged commit f188473 into master Oct 27, 2021
@metacosm metacosm deleted the forbid-multiple-controller-per-cr branch October 27, 2021 08:15
@csviri
Copy link
Collaborator

csviri commented Oct 27, 2021

Should we cherry pick to v2?

@metacosm
Copy link
Collaborator Author

Should we cherry pick to v2?

I did already :)

@csviri
Copy link
Collaborator

csviri commented Oct 27, 2021

Excellent! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It shouldn't be possible to register several controllers for the same custom resource
2 participants
@metacosm @csviri