Skip to content

improve: GenericRetry does not provide mutable singleton instance #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

improve: GenericRetry does not provide mutable singleton instance #2934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rk-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ default boolean isGenerationAware() {
String getAssociatedReconcilerClassName();

default Retry getRetry() {
return GenericRetry.DEFAULT;
return GenericRetry.defaultLimitedExponentialRetry();
}

@SuppressWarnings("rawtypes")
Expand Down
7 changes: 6 additions & 1 deletion ...amework-core/src/main/java/io/javaoperatorsdk/operator/processing/retry/GenericRetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@ public class GenericRetry implements Retry, AnnotationConfigurable<GradualRetry>
private double intervalMultiplier = GradualRetry.DEFAULT_MULTIPLIER;
private long maxInterval = GradualRetry.DEFAULT_MAX_INTERVAL;

/**
* @deprecated use {@link GenericRetry#defaultLimitedExponentialRetry()} instead this instance.
* Since GenericRetry is mutable, singleton is problematic.
*/
@Deprecated(forRemoval = true)
public static final Retry DEFAULT = new GenericRetry();

public static GenericRetry defaultLimitedExponentialRetry() {
return (GenericRetry) DEFAULT;
return new GenericRetry();
}

public static GenericRetry noRetry() {
Expand Down