-
Notifications
You must be signed in to change notification settings - Fork 230
feat: field selectors support for InformerEventSource #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2d43aff
feat: field selectors support for InformerEventSource
csviri 755c404
Annotation config + controller IT
csviri 9abfa33
test + inform api
csviri 21aced8
javadoc
csviri ddffb97
refactor
csviri c2db437
fix
csviri fb32972
naming
csviri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Field.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package io.javaoperatorsdk.operator.api.config.informer; | ||
|
||
public @interface Field { | ||
|
||
String path(); | ||
|
||
String value(); | ||
|
||
boolean negate() default false; | ||
} |
26 changes: 26 additions & 0 deletions
26
...ork-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package io.javaoperatorsdk.operator.api.config.informer; | ||
|
||
import java.util.Arrays; | ||
import java.util.List; | ||
|
||
public class FieldSelector { | ||
private final List<Field> fields; | ||
|
||
public FieldSelector(List<Field> fields) { | ||
this.fields = fields; | ||
} | ||
|
||
public FieldSelector(Field... fields) { | ||
this.fields = Arrays.asList(fields); | ||
} | ||
|
||
public List<Field> getFields() { | ||
return fields; | ||
} | ||
|
||
public record Field(String path, String value, boolean negated) { | ||
public Field(String value, String path) { | ||
this(path, value, false); | ||
} | ||
} | ||
} |
23 changes: 23 additions & 0 deletions
23
...e/src/main/java/io/javaoperatorsdk/operator/api/config/informer/FieldSelectorBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package io.javaoperatorsdk.operator.api.config.informer; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class FieldSelectorBuilder { | ||
|
||
private final List<FieldSelector.Field> fields = new ArrayList<>(); | ||
|
||
public FieldSelectorBuilder withField(String path, String value) { | ||
fields.add(new FieldSelector.Field(path, value)); | ||
return this; | ||
} | ||
|
||
public FieldSelectorBuilder withoutField(String path, String value) { | ||
fields.add(new FieldSelector.Field(path, value, true)); | ||
return this; | ||
} | ||
|
||
public FieldSelector build() { | ||
return new FieldSelector(fields); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
...work/src/test/java/io/javaoperatorsdk/operator/baseapi/fieldselector/FieldSelectorIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
package io.javaoperatorsdk.operator.baseapi.fieldselector; | ||
|
||
import java.time.Duration; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
||
import io.fabric8.kubernetes.api.model.ObjectMetaBuilder; | ||
import io.fabric8.kubernetes.api.model.SecretBuilder; | ||
import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension; | ||
import io.javaoperatorsdk.operator.processing.event.ResourceID; | ||
|
||
import static io.javaoperatorsdk.operator.baseapi.fieldselector.FieldSelectorTestReconciler.MY_SECRET_TYPE; | ||
import static io.javaoperatorsdk.operator.baseapi.fieldselector.FieldSelectorTestReconciler.OTHER_SECRET_TYPE; | ||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.awaitility.Awaitility.await; | ||
|
||
class FieldSelectorIT { | ||
|
||
public static final String TEST_1 = "test1"; | ||
public static final String TEST_2 = "test2"; | ||
public static final String TEST_3 = "test3"; | ||
|
||
@RegisterExtension | ||
LocallyRunOperatorExtension extension = | ||
LocallyRunOperatorExtension.builder() | ||
.withReconciler(new FieldSelectorTestReconciler()) | ||
.build(); | ||
|
||
@Test | ||
void filtersCustomResourceByLabel() { | ||
|
||
var customPrimarySecret = | ||
extension.create( | ||
new SecretBuilder() | ||
.withMetadata(new ObjectMetaBuilder().withName(TEST_1).build()) | ||
.withType(MY_SECRET_TYPE) | ||
.build()); | ||
|
||
var otherSecret = | ||
extension.create( | ||
new SecretBuilder() | ||
.withMetadata(new ObjectMetaBuilder().withName(TEST_2).build()) | ||
.build()); | ||
|
||
var dependentSecret = | ||
extension.create( | ||
new SecretBuilder() | ||
.withMetadata(new ObjectMetaBuilder().withName(TEST_3).build()) | ||
.withType(OTHER_SECRET_TYPE) | ||
.build()); | ||
|
||
await() | ||
.pollDelay(Duration.ofMillis(150)) | ||
.untilAsserted( | ||
() -> { | ||
var r = extension.getReconcilerOfType(FieldSelectorTestReconciler.class); | ||
assertThat(r.getReconciledSecrets()).containsExactly(TEST_1); | ||
|
||
assertThat( | ||
r.getDependentSecretEventSource() | ||
.get(ResourceID.fromResource(dependentSecret))) | ||
.isPresent(); | ||
assertThat( | ||
r.getDependentSecretEventSource() | ||
.get(ResourceID.fromResource(customPrimarySecret))) | ||
.isNotPresent(); | ||
assertThat( | ||
r.getDependentSecretEventSource().get(ResourceID.fromResource(otherSecret))) | ||
.isNotPresent(); | ||
}); | ||
} | ||
} |
69 changes: 69 additions & 0 deletions
69
...t/java/io/javaoperatorsdk/operator/baseapi/fieldselector/FieldSelectorTestReconciler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
package io.javaoperatorsdk.operator.baseapi.fieldselector; | ||
|
||
import java.util.Collections; | ||
import java.util.HashSet; | ||
import java.util.List; | ||
import java.util.Set; | ||
import java.util.concurrent.atomic.AtomicInteger; | ||
|
||
import io.fabric8.kubernetes.api.model.Secret; | ||
import io.javaoperatorsdk.operator.api.config.informer.Field; | ||
import io.javaoperatorsdk.operator.api.config.informer.FieldSelectorBuilder; | ||
import io.javaoperatorsdk.operator.api.config.informer.Informer; | ||
import io.javaoperatorsdk.operator.api.config.informer.InformerEventSourceConfiguration; | ||
import io.javaoperatorsdk.operator.api.reconciler.Context; | ||
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration; | ||
import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext; | ||
import io.javaoperatorsdk.operator.api.reconciler.Reconciler; | ||
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl; | ||
import io.javaoperatorsdk.operator.processing.event.source.EventSource; | ||
import io.javaoperatorsdk.operator.processing.event.source.informer.InformerEventSource; | ||
import io.javaoperatorsdk.operator.support.TestExecutionInfoProvider; | ||
|
||
@ControllerConfiguration( | ||
informer = | ||
@Informer( | ||
fieldSelector = | ||
@Field(path = "type", value = FieldSelectorTestReconciler.MY_SECRET_TYPE))) | ||
public class FieldSelectorTestReconciler implements Reconciler<Secret>, TestExecutionInfoProvider { | ||
|
||
public static final String MY_SECRET_TYPE = "my-secret-type"; | ||
public static final String OTHER_SECRET_TYPE = "my-dependent-secret-type"; | ||
private final AtomicInteger numberOfExecutions = new AtomicInteger(0); | ||
|
||
private Set<String> reconciledSecrets = Collections.synchronizedSet(new HashSet<>()); | ||
private InformerEventSource<Secret, Secret> dependentSecretEventSource; | ||
|
||
@Override | ||
public UpdateControl<Secret> reconcile(Secret resource, Context<Secret> context) { | ||
reconciledSecrets.add(resource.getMetadata().getName()); | ||
numberOfExecutions.addAndGet(1); | ||
return UpdateControl.noUpdate(); | ||
} | ||
|
||
public int getNumberOfExecutions() { | ||
return numberOfExecutions.get(); | ||
} | ||
|
||
public Set<String> getReconciledSecrets() { | ||
return reconciledSecrets; | ||
} | ||
|
||
@Override | ||
public List<EventSource<?, Secret>> prepareEventSources(EventSourceContext<Secret> context) { | ||
dependentSecretEventSource = | ||
new InformerEventSource<>( | ||
InformerEventSourceConfiguration.from(Secret.class, Secret.class) | ||
.withNamespacesInheritedFromController() | ||
.withFieldSelector( | ||
new FieldSelectorBuilder().withField("type", OTHER_SECRET_TYPE).build()) | ||
.build(), | ||
context); | ||
|
||
return List.of(dependentSecretEventSource); | ||
} | ||
|
||
public InformerEventSource<Secret, Secret> getDependentSecretEventSource() { | ||
return dependentSecretEventSource; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.