Skip to content

improve: more strict delete condition #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2025
Merged

improve: more strict delete condition #2722

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba04b2e
improve: logging on resource delete condition
csviri Mar 9, 2025
1649e28
wip
csviri Mar 9, 2025
7d2a5bf
wip
csviri Mar 9, 2025
bcdfc7e
format
csviri Mar 9, 2025
76819d5
Add docs
csviri Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions ...peratorsdk/operator/processing/dependent/workflow/KubernetesResourceDeletedCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,9 @@
import io.javaoperatorsdk.operator.api.reconciler.Context;
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;

/**
* A condition implementation meant to be used as a delete post-condition on Kubernetes dependent
/* A condition implementation meant to be used as a delete post-condition on Kubernetes dependent
* resources to prevent the workflow from proceeding until the associated resource is actually
* deleted from the server (or, at least, doesn't have any finalizers anymore). This is needed in
* cases where a cleaning process depends on resources being actually removed from the server
* because, by default, workflows simply request the deletion but do NOT wait for the resources to
* be actually deleted.
* deleted from the server.
*/
public class KubernetesResourceDeletedCondition implements Condition<HasMetadata, HasMetadata> {

Expand All @@ -20,10 +16,6 @@ public boolean isMet(
HasMetadata primary,
Context<HasMetadata> context) {
var optionalResource = dependentResource.getSecondaryResource(primary, context);
if (optionalResource.isEmpty()) {
return true;
} else {
return optionalResource.orElseThrow().getMetadata().getFinalizers().isEmpty();
}
return optionalResource.isEmpty();
}
}